feat(ci): add a dry_run input to rehearse the release pipeline - #32
Open
danceratopz wants to merge 1 commit into
Open
feat(ci): add a dry_run input to rehearse the release pipeline#32danceratopz wants to merge 1 commit into
danceratopz wants to merge 1 commit into
Conversation
Everything schedule-specific in the release workflow keys on `github.event_name == 'schedule'`, which cannot be triggered by hand, and the cron path cannot run in PR CI, so the first real execution of the nightly behavior would be the 02:00 run itself. Add a `dry_run` boolean dispatch input that follows the same no-release path for any feature: the `release` job is skipped (no tag, no draft), `fail-fast` is disabled so every fork range reports, nightly artifact retention applies and the run queues in the `nightly-fill` concurrency group. Dry runs are dispatch events, so the nightly baseline in `check_new_commits.py` (filtered on `event=schedule`) never counts them.
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
The schedule path keys entirely on
github.event_name == 'schedule'and cannot run in PR CI, so the first real execution of the merged nightly behavior would be the 02:00 cron itself. This adds adry_runboolean dispatch input that follows the same no-release path from the Actions UI: thereleasejob is skipped (no tag, no draft),fail-fastis off so every fork range reports, nightly artifact retention applies, and the run queues in thenightly-fillconcurrency group. Dry runs are dispatch events, so the nightly baseline incheck_new_commits.py(filtered onevent=schedule) never counts them, and #31's promotion can never select their artifacts. Composes with anyfeature, so benchmark and devnet releases can be rehearsed end-to-end too.🔗 Related Issues or PRs
Targets the head branch of ethereum#3100; complements #31.
✅ Checklist
just static<type>(<area>):, where<type>and<area>come from an approrpriateC-<type>, respectivelyA-<area>, label. The title should match the a target squash commit message.Cute Animal Picture