Skip to content

fix(ci): use fresh acceptance for current stable #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pallyoung merged 1 commit into from
Aug 13, 2026
Merged

fix(ci): use fresh acceptance for current stable #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/desktop-acceptance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ jobs:
acceptance_scenarios: ${{ steps.channel.outputs.acceptance_scenarios }}

steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Resolve acceptance channel
id: channel
shell: bash
Expand All @@ -49,6 +52,17 @@ jobs:
has_previous_desktop=false
if gh api "repos/${GITHUB_REPOSITORY}/releases/latest" > "${latest_release_json}" 2> "${latest_release_error}"; then
has_previous_desktop=$(node -e "const release=require(process.argv[1]); process.stdout.write(Array.isArray(release.assets)&&release.assets.some((asset)=>asset?.name==='desktop-channel.json')?'true':'false')" "${latest_release_json}")
if [[ "${has_previous_desktop}" == "true" ]]; then
latest_tag=$(node -e "const release=require(process.argv[1]); process.stdout.write(release.tag_name)" "${latest_release_json}")
latest_channel="${RUNNER_TEMP}/coder-studio-latest-channel.json"
gh release download "${latest_tag}" \
--repo "${GITHUB_REPOSITORY}" \
--pattern desktop-channel.json \
--output "${latest_channel}"
current_shell=$(node -p "require('./packages/desktop/package.json').version")
current_runtime=$(node -p "require('./packages/cli/package.json').version")
has_previous_desktop=$(node -e "const channel=require(process.argv[1]); const currentShell=process.argv[2]; const currentRuntime=process.argv[3]; process.stdout.write(channel?.shell?.version===currentShell&&channel?.runtimes?.['win32-x64']?.version===currentRuntime&&channel?.runtimes?.['linux-x64']?.version===currentRuntime?'false':'true')" "${latest_channel}" "${current_shell}" "${current_runtime}")
fi
elif ! grep -q '(HTTP 404)' "${latest_release_error}"; then
cat "${latest_release_error}" >&2
exit 1
Expand Down
5 changes: 5 additions & 0 deletions scripts/github-workflows.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,11 @@ describe("GitHub workflow boundaries", () => {
'public_key_artifact="desktop-acceptance-public-key-${GITHUB_RUN_ID}-${GITHUB_RUN_ATTEMPT}"'
);
expect(resolveChannel?.run).toContain("has_previous_desktop=false");
expect(resolveChannel?.run).toContain('--repo "${GITHUB_REPOSITORY}"');
expect(resolveChannel?.run).toContain("require('./packages/desktop/package.json').version");
expect(resolveChannel?.run).toContain("require('./packages/cli/package.json').version");
expect(resolveChannel?.run).toContain("channel?.shell?.version===currentShell");
expect(resolveChannel?.run).toContain("?'false':'true'");
expect(resolveChannel?.run).toContain('acceptance_scenarios=\'["fresh-native","fresh-wsl"]\'');
expect(generateKey?.run).toContain("openssl genpkey -algorithm Ed25519");
expect(signingKeyUpload?.with).toMatchObject({
Expand Down
Loading