Skip to content

fix(ci): carry forward desktop blockmaps #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pallyoung merged 1 commit into from
Aug 14, 2026
Merged

fix(ci): carry forward desktop blockmaps #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/desktop-acceptance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,23 @@ jobs:
name: ${{ needs.build-assets.outputs.complete_artifact }}
path: release/desktop-acceptance

- name: Carry forward previous Shell blockmap for differential updates
if: needs.prepare.outputs.has_previous_desktop == 'true' && needs.prepare.outputs.release_kind == 'full'
shell: bash
env:
GH_TOKEN: ${{ github.token }}
run: |
latest_tag=$(gh api "repos/${GITHUB_REPOSITORY}/releases/latest" --jq .tag_name)
previous_metadata="${RUNNER_TEMP}/coder-studio-previous-latest.yml"
gh release download "${latest_tag}" \
--pattern latest.yml \
--output "${previous_metadata}"
previous_installer=$(node -e "const { readFileSync } = require('node:fs'); const { parse } = require('yaml'); const value = parse(readFileSync(process.argv[1], 'utf8')).path; if (typeof value !== 'string' || !value) process.exit(1); process.stdout.write(value)" "${previous_metadata}")
gh release download "${latest_tag}" \
--pattern "${previous_installer}.blockmap" \
--dir release/desktop-acceptance \
--clobber

- name: Download acceptance public key
uses: actions/download-artifact@v4
with:
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,23 @@ jobs:
path: release/desktop-release-final
merge-multiple: true

- name: Carry forward previous Shell blockmap for differential updates
if: needs.prepare.outputs.has_previous_desktop == 'true' && needs.prepare.outputs.release_kind == 'full'
shell: bash
env:
GH_TOKEN: ${{ github.token }}
run: |
latest_tag=$(gh api "repos/${GITHUB_REPOSITORY}/releases/latest" --jq .tag_name)
previous_metadata="${RUNNER_TEMP}/coder-studio-previous-latest.yml"
gh release download "${latest_tag}" \
--pattern latest.yml \
--output "${previous_metadata}"
previous_installer=$(node -e "const { readFileSync } = require('node:fs'); const { parse } = require('yaml'); const value = parse(readFileSync(process.argv[1], 'utf8')).path; if (typeof value !== 'string' || !value) process.exit(1); process.stdout.write(value)" "${previous_metadata}")
gh release download "${latest_tag}" \
--pattern "${previous_installer}.blockmap" \
--dir release/desktop-release-final \
--clobber

- name: Build signed Desktop channel
shell: bash
run: |
Expand Down
36 changes: 35 additions & 1 deletion scripts/github-workflows.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,15 @@ describe("GitHub workflow boundaries", () => {
const publicKeyDownload = publishSteps.find(
(step) => step.name === "Download acceptance public key"
);
const previousShellBlockmapIndex = publishSteps.findIndex(
(step) => step.name === "Carry forward previous Shell blockmap for differential updates"
);
const validation = publishSteps.find(
(step) => step.name === "Validate complete signed acceptance channel"
);
const validationIndex = publishSteps.findIndex(
(step) => step.name === "Validate complete signed acceptance channel"
);
const release = publishSteps.find((step) => step.name === "Publish tag-pinned prerelease");

expect(workflow.on).toEqual({
Expand Down Expand Up @@ -318,6 +324,19 @@ describe("GitHub workflow boundaries", () => {
name: "${{ needs.prepare.outputs.public_key_artifact }}",
path: "release/desktop-ci-signing",
});
expect(previousShellBlockmapIndex).toBeGreaterThan(-1);
expect(previousShellBlockmapIndex).toBeLessThan(validationIndex);
expect(publishSteps[previousShellBlockmapIndex]?.if).toBe(
"needs.prepare.outputs.has_previous_desktop == 'true' && needs.prepare.outputs.release_kind == 'full'"
);
expect(publishSteps[previousShellBlockmapIndex]?.run).toContain(
'--pattern "${previous_installer}.blockmap"'
);
expect(publishSteps[previousShellBlockmapIndex]?.run).toContain("--pattern latest.yml");
expect(publishSteps[previousShellBlockmapIndex]?.run).toContain("require('yaml')");
expect(publishSteps[previousShellBlockmapIndex]?.run).toContain(
"--dir release/desktop-acceptance"
);
expect(validation?.run).toContain(
"validate --directory release/desktop-acceptance --components 'desktop,win-runtime,wsl-engine,wsl-runtime'"
);
Expand Down Expand Up @@ -441,6 +460,9 @@ describe("GitHub workflow boundaries", () => {
const channelIndex = publishSteps.findIndex(
(step) => step.name === "Build signed Desktop channel"
);
const previousShellBlockmapIndex = publishSteps.findIndex(
(step) => step.name === "Carry forward previous Shell blockmap for differential updates"
);
const productionValidateIndex = publishSteps.findIndex(
(step) => step.name === "Validate complete production release"
);
Expand All @@ -450,10 +472,22 @@ describe("GitHub workflow boundaries", () => {
);
expect(previousIndex).toBeGreaterThan(-1);
expect(carryIndex).toBeGreaterThan(previousIndex);
expect(channelIndex).toBeGreaterThan(carryIndex);
expect(previousShellBlockmapIndex).toBeGreaterThan(carryIndex);
expect(channelIndex).toBeGreaterThan(previousShellBlockmapIndex);
expect(productionValidateIndex).toBeGreaterThan(channelIndex);
expect(attestIndex).toBeGreaterThan(productionValidateIndex);
expect(releaseIndex).toBeGreaterThan(attestIndex);
expect(publishSteps[previousShellBlockmapIndex]?.if).toBe(
"needs.prepare.outputs.has_previous_desktop == 'true' && needs.prepare.outputs.release_kind == 'full'"
);
expect(publishSteps[previousShellBlockmapIndex]?.run).toContain(
'--pattern "${previous_installer}.blockmap"'
);
expect(publishSteps[previousShellBlockmapIndex]?.run).toContain("--pattern latest.yml");
expect(publishSteps[previousShellBlockmapIndex]?.run).toContain("require('yaml')");
expect(publishSteps[previousShellBlockmapIndex]?.run).toContain(
"--dir release/desktop-release-final"
);
expect(publishSteps[productionValidateIndex]?.run).toContain("--release-kind");
expect(publishSteps[releaseIndex]?.run).toContain("--prerelease --latest=false");
expect(publishSteps[releaseIndex]?.run).toContain("not Authenticode-signed");
Expand Down
Loading