Skip to content

fix(ci): accept pnpm argument separator - #121

Merged
pallyoung merged 1 commit into
mainfrom
develop
Aug 17, 2026
Merged

fix(ci): accept pnpm argument separator#121
pallyoung merged 1 commit into
mainfrom
develop

Conversation

@pallyoung

Copy link
Copy Markdown
Contributor

What changed

  • accept the optional leading -- that pnpm forwards to the full-download release helper on Linux
  • add a regression test for both direct and pnpm-separated argument forms

Why

Desktop acceptance run 31992674354 stopped before publishing its candidate because Linux passed -- --directory ... to the helper and the strict argument parser rejected the separator. No release asset was modified.

Validation

  • pnpm exec vitest run --config scripts/vitest.config.ts --environment node scripts/force-desktop-full-download.test.ts (3 passed)
  • targeted Biome check passed
  • git diff --check passed

@pallyoung
pallyoung marked this pull request as ready for review August 17, 2026 04:12
@pallyoung
pallyoung merged commit ebc64f0 into main Aug 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant