Skip to content

qml: add wallets search option#10741

Open
accumulator wants to merge 2 commits into
spesmilo:masterfrom
accumulator:qml_hidden_wallet
Open

qml: add wallets search option#10741
accumulator wants to merge 2 commits into
spesmilo:masterfrom
accumulator:qml_hidden_wallet

Conversation

@accumulator

@accumulator accumulator commented Jul 7, 2026

Copy link
Copy Markdown
Member

qml: add wallets search option, allow loading hidden wallet iff search string matches exact wallet name

ref #10715
ref #10688

@accumulator
accumulator marked this pull request as draft July 9, 2026 06:58
@accumulator
accumulator marked this pull request as ready for review July 9, 2026 07:47
local_password = password # need this in local scope
wallet = None
try:
wallet = self.daemon.load_wallet(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daemon.load_wallet() sets config.RECENTLY_OPEN_WALLET_FILES and config.CURRENT_WALLET causing the app to open a hidden wallet on the next restart if it was the last opened wallet before.
Should we allow this? In the end the user might be forced to open the app (e.g. with the fingerprint) and then their secret wallet would show up. Maybe we should just open the wallet list on startup or the last non-hidden wallet.

@f321x

f321x commented Jul 15, 2026

Copy link
Copy Markdown
Member

Should we make the user aware of this feature somehow, either in the wallet details view (renaming) or in the wizard?
Otherwise I'd expect only few will find this feature.

Considering that the experience of creating a new wallet in the wizard is already stressful for users it might be better to not add even more mental load to the wizard and show it somewhere else?

Or maybe a "Hide" button (e.g. in the rename box or somewhere else in the wallet details view), that when clicked, automatically changes the name and opens a popup explaining the user how they can access their wallet through the search box?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants