qml: update ConfirmTxDialog onValidChanged#10754
Open
f321x wants to merge 1 commit into
Open
Conversation
Commit 2de11ea gated the ConfirmTxDialog amount behind `finalizer.valid`. When sweeping private keys from the sweep view the resulting `ConfirmTxDialog` is not valid in the beginning, and after it turns valid nothing causes it to update. This results in the amount being displayed as `0` even after it finished fetching the keys balances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 2de11ea gated the ConfirmTxDialog amount behind
finalizer.valid.When sweeping private keys from the sweep view the resulting
ConfirmTxDialogis not valid in the beginning, and after it turns valid nothing causes it to update. This results in the amount being displayed as0even after it finished fetching the keys balances.