fix: include subpath in module import path when init with directory arg#126
Open
hanzhuoxian wants to merge 1 commit into
Open
fix: include subpath in module import path when init with directory arg#126hanzhuoxian wants to merge 1 commit into
hanzhuoxian wants to merge 1 commit into
Conversation
When running `cobra-cli init <dir>`, the generated project was created under <dir>/ on disk but the Go module import path did not include <dir>, causing the import statement in main.go to point to a non-existent package. Pass the user-supplied path argument through fileToURL (for Windows backslash normalisation) before appending it to the import path, keeping the filesystem path and Go import path consistent.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
/ on disk but the Go module import path did not include , causing the import statement in main.go to point to a non-existent package.cobra-cli init <dir>, the generated project was created underPass the user-supplied path argument through fileToURL (for Windows backslash normalisation) before appending it to the import path, keeping the filesystem path and Go import path consistent.