Skip to content

Adds an example of using toolchains to resolve multiple environments.#28

Draft
jiawen wants to merge 1 commit into
spietras:mainfrom
jiawen:toolchain
Draft

Adds an example of using toolchains to resolve multiple environments.#28
jiawen wants to merge 1 commit into
spietras:mainfrom
jiawen:toolchain

Conversation

@jiawen
Copy link
Copy Markdown
Contributor

@jiawen jiawen commented Nov 11, 2021

No description provided.

@jiawen
Copy link
Copy Markdown
Contributor Author

jiawen commented Nov 11, 2021

Related: #28.

Turns out we don't need platforms.

Comment thread tests/miniconda/WORKSPACE
# The name argument is required because `register_toolchain` constructs a single external repository
# and writes a BUILD file into it.
register_toolchain(
name = "test2",
Copy link
Copy Markdown
Contributor Author

@jiawen jiawen Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok but might be irritating to use - because the rule makes a single BUILD file. Maybe add an extra register_toolchains function that lets you pass in multiple envs and names?

Copy link
Copy Markdown
Owner

@spietras spietras Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First thought: We can name it after the environment name, like test2_env_toolchain. That way only the environment name would be needed.

Second thought: One function that registers all toolchains might be better to enforce correctness and even maybe more user-friendly. Depends on how exactly the arguments will be passed.

@jiawen
Copy link
Copy Markdown
Contributor Author

jiawen commented Nov 11, 2021

@spietras Any idea what's going on with the Windows test? I haven't touched Anaconda on Windows in a long time but AFAICT, I'm not doing anything obviously wrong.

@GabrielDougherty
Copy link
Copy Markdown
Contributor

@jiawen The first thing I would try is to increase the CACHE_NUMBER in the github workflow, to try to fix what looks like a corrupted cache maybe. Do you have a Windows workstation on hand to test with locally?

@jiawen
Copy link
Copy Markdown
Contributor Author

jiawen commented Nov 11, 2021

@jiawen The first thing I would try is to increase the CACHE_NUMBER in the github workflow, to try to fix what looks like a corrupted cache maybe. Do you have a Windows workstation on hand to test with locally?

Surprisingly yes :). Let me give that a shot.

I know nothing about GitHub workflows - time to learn I guess. 🤷

@spietras
Copy link
Copy Markdown
Owner

Yet another possibility might be because of the PATH issue as I forgot to actually set the CONDA_DLL_SEARCH_MODIFICATION_ENABLE variable in tests...

@spietras spietras marked this pull request as draft November 19, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants