Add conda bin to built apps#53
Open
leriel wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, and thanks a lot for your awesome work with conda rules!
Unfortunately, for some conda packages, combination of py_runtime+interpreter pointing to conda python will not be enough. As i understand, conda packages can be devided into at least three categories:
jbig2decexecutable to handle them.export TESSDATA_PREFIX=$CONDA_PREFIX/share/tessdata/. It can't be ran standalone, as it relies on$CONDA_PREFIXwhich comes fromconda activate. This is much harder nut to crack and not covered by this PR, but i might be able to figure out something for this later on.One other way to add conda bin to py_runtime path is to extend entire
bootstrap_template, but that's a lot of code that would need to be kept in this repo and a huge lockdown, with need to update upstream.stub_shebangis still a lockdown but much smaller and so much easier to fix in an event of upstream change.