Add jwt_svid_include_jti to Entry.AdditionalAttributes#95
Merged
Conversation
Extends the AdditionalAttributes sub-message with a new bool `jwt_svid_include_jti` (field 2). When set, SPIRE includes a unique JTI (JWT ID) claim in JWT-SVIDs issued for the entry, and the agent bypasses its JWT-SVID cache so every request yields a fresh token. This supports use cases that require per-token uniqueness such as replay protection or auditing. Builds on the AdditionalAttributes sub-message introduced by spiffe#88. Signed-off-by: Srikalyan Swayampakula <srikalyansswayam@gmail.com>
srikalyan
requested review from
amartinezfayo,
azdagron,
evan2645 and
rturner3
as code owners
sorindumitru
approved these changes
Apr 27, 2026
Member
sorindumitru
left a comment
sorindumitru
left a comment
There was a problem hiding this comment.
LGTM, thanks @srikalyan. I'll also have a look at the SPIRE PR
Author
|
Thank you @sorindumitru can we merge this, becomes easier on the implementation PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
bool jwt_svid_include_jtifield toEntry.AdditionalAttributes(field number 2, scoped inside the nested sub-message introduced by #88).When set to true on a registration entry, SPIRE:
jticlaim of every JWT-SVID minted for the entry.This supports use cases that require per-token uniqueness, such as replay protection or auditing.
Background
This replaces the prior approach (an enum + per-audience policy map, previously proposed in #84) with a single boolean, following upstream feedback from @sorindumitru. The corresponding SPIRE PR is spiffe/spire#6514.
Test plan
make generateregeneratesentry.pb.gocleanly