Upgrade controller-runtime to latest 0.24.1#670
Merged
Conversation
Signed-off-by: Alec Holmes <alec.holmes@greymatter.io>
Signed-off-by: Alec Holmes <alec.holmes@greymatter.io>
Signed-off-by: Alec Holmes <alec.holmes@greymatter.io>
Contributor
Author
|
I just addressed the last deprecation warning for the scheme builder. The deprecation warning example seems to imply that the new pattern is registering types in a central location, which I followed here. If everyone prefers that I split that back out I can do so just let me know. |
MarcosDY
reviewed
May 14, 2026
Collaborator
MarcosDY
left a comment
MarcosDY
left a comment
There was a problem hiding this comment.
Looks great just a question,
why you use a commit on protobuf? can you use the tag instead?
Signed-off-by: Alec Holmes <alec.holmes@greymatter.io>
Signed-off-by: Alec Holmes <alec.holmes@greymatter.io>
MarcosDY
reviewed
May 14, 2026
Signed-off-by: Alec Holmes <alec.holmes@greymatter.io>
Signed-off-by: Alec Holmes <alec.holmes@greymatter.io>
Contributor
Author
|
@MarcosDY Should be at 1.26.3 across the board now |
MarcosDY
approved these changes
May 14, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change bumps controller-runtime to 0.24.1 (latest release as of May 13th, 2026), and updates the manager webhook registration to use the new generics support introduced in controller-runtime 0.23.0.
See breaking changes for more info:
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.23.0