Skip to content

Add multiple configuration support #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MarcosDY wants to merge 1 commit into
base: next
Choose a base branch
from
+156 −44
Draft

Add multiple configuration support #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
174 changes: 138 additions & 36 deletions proto/spire/service/common/config/v1/config.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 18 additions & 8 deletions proto/spire/service/common/config/v1/config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,33 @@ service Config {
rpc Validate(ValidateRequest) returns (ValidateResponse);
}

enum ConfigFormat {
CONFIG_FORMAT_UNSPECIFIED = 0;
CONFIG_FORMAT_HCL = 1;
CONFIG_FORMAT_YAML = 2;
}

message ConfigureRequest {
// Required. Core SPIRE configuration.
CoreConfiguration core_configuration = 1;

// Required. HCL encoded plugin configuration.
string hcl_configuration = 2;
// Deprecated: use configuration with config_format. Kept for backward compat with old plugins.
string hcl_configuration = 2 [deprecated = true];
// Raw plugin configuration string in the format specified by configFormat.
// When set, takes precedence over hclConfiguration.
string configuration = 3;
ConfigFormat config_format = 4;
}

message ConfigureResponse {
}

message ValidateRequest {
// Required. Core SPIRE configuration.
CoreConfiguration core_configuration = 1;

// Required. HCL encoded plugin configuration.
string hcl_configuration = 2;
// Deprecated: use configuration with config_format. Kept for backward compat with old plugins.
string hcl_configuration = 2 [deprecated = true];
// Raw plugin configuration string in the format specified by configFormat.
// When set, takes precedence over hclConfiguration.
string configuration = 3;
ConfigFormat config_format = 4;
}

message ValidateResponse {
Expand Down
Loading