Enhance SPIRE Quickstart Tutorial for kubeadm based Kubernetes#135
Open
saiakhil2012 wants to merge 2 commits intospiffe:mainfrom
Open
Enhance SPIRE Quickstart Tutorial for kubeadm based Kubernetes#135saiakhil2012 wants to merge 2 commits intospiffe:mainfrom
saiakhil2012 wants to merge 2 commits intospiffe:mainfrom
Conversation
fca1e24 to
91e97fb
Compare
Signed-off-by: Bala Siva Sai Akhil Malepati <saiakhil2012@yahoo.com>
Signed-off-by: Bala Siva Sai Akhil Malepati <saiakhil2012@yahoo.com>
91e97fb to
b8bebe4
Compare
Author
|
@rturner3 greetings, I saw you had worked on this repo before and reviewed past PRs. Requesting you to review this PR or suggest anyone else who can review this PR, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this PR to add couple of files to the
k8s/quickstartdirectory to enhance the SPIFFE Documentation related to K8S Quick start for users using kubeadm based K8S Clusters.When I was trying to utilize SPIFFE Documentation https://spiffe.io/docs/latest/try/getting-started-k8s/ using kubeadm based K8S cluster, it was involved to setup other storage classes and made following the tutorial less streamlined.
Adding local storage based storage class and persistent volume related yaml files.
Once this PR is merged, will raise another PR in https://github.com/spiffe/spiffe.io to modify the corresponding getting started guide (i.e. https://github.com/spiffe/spiffe.io/blob/master/content/docs/latest/try/getting-started-k8s.md) to add a section,
Considerations When Using Kubeadmsimilar to the one for Minikube.There is an associated issue as well, "Tutorial fails when installing spire server" (#91), raised couple of years back which is still
Open. With the change in this PR and a subsequent PR inspiffie.iorepo as mentioned above, the #91 issue can be resolved as well.