k8s/quickstart: specify default namespace for client deployment#144
Open
fantashley wants to merge 1 commit intospiffe:mainfrom
Open
k8s/quickstart: specify default namespace for client deployment#144fantashley wants to merge 1 commit intospiffe:mainfrom
fantashley wants to merge 1 commit intospiffe:mainfrom
Conversation
The registration entry for the workload specifies a selector of `k8s:ns:default`, which means the workload should be running in the default namespace. If the namespace isn't specified in the yaml, the workload will deploy to whichever namespace your context is currently set to, which can cause issue spiffe#123. Fixes spiffe#123. Signed-off-by: Ashley Nelson <amn@fantashley.com>
fantashley
force-pushed
the
k8s-quickstart-fix
branch
from
5213046 to
86adca6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registration entry for the workload specifies a selector of
k8s:ns:default, which means the workload should be running in the default namespace. If the namespace isn't specified in client-deployment.yaml, the workload will deploy to whichever namespace your context is currently set to, which can cause issue #123.Fixes #123.