Implement SPIFFE Broker Endpoint & API#6915
Draft
matheuscscp wants to merge 1 commit into
Draft
Conversation
This was referenced Apr 30, 2026
Author
|
@arndt-s @amartinezfayo @MarcosDY @sorindumitru I spiked through the implementation, will add tests and docs after an initial review. PTAL 🙏 |
Author
|
@sorindumitru I updated the PR according to the spire-plugin-sdk changes your requested (remove workloadattestorv2), PTAL 🙏 |
arndt-s
reviewed
May 5, 2026
Member
arndt-s
left a comment
arndt-s
left a comment
There was a problem hiding this comment.
Structural-wise I believe this is looking good.
Author
|
@arndt-s Addressed your first three comments here: https://github.com/spiffe/spire/compare/4973fcf5ee282081a3025b9c1faf68a06bd79368..cfe8a847be3432652de75e7aa386f5a68aa51700 |
matheuscscp
force-pushed
the
broker-api
branch
2 times, most recently
from
e492e76 to
2a814e3
Compare
sorindumitru
reviewed
May 7, 2026
matheuscscp
force-pushed
the
broker-api
branch
2 times, most recently
from
0ba6010 to
97772d7
Compare
MarcosDY
reviewed
May 13, 2026
matheuscscp
force-pushed
the
broker-api
branch
9 times, most recently
from
39cd713 to
c4b0c6c
Compare
matheuscscp
force-pushed
the
broker-api
branch
9 times, most recently
from
7ed5c34 to
fe96fc1
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Work In Progress.
Reference implementation for spiffe/spiffe#340 arndt-s/spiffe#1
api-sdk PR: spiffe/spire-api-sdk#96 plugin-sdk PR: spiffe/spire-plugin-sdk#74
Pull Request check list
Affected functionality
Description of change
Which issue this PR fixes
Supersedes: #6594