Skip to content

Don't abort pmap when a linked process exits normally #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevin-spil wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't abort pmap when a linked process exits normally #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/spr_util.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,12 @@ do_f(Parent, Ref, F, I) ->
gather([Pid|T]=L, Ref, Timeout, Acc) ->
receive
{Pid, Ref, Ret} -> gather(T, Ref, Timeout, [Ret|Acc]);
{'EXIT', _, Reason} ->
% NOTE: This can only originate from non-worker processes, as they
% are spawned and not linked. There is also a catch for workers,
% so they just return {'EXIT', Reason} when they fail instead of sending a message.
{'EXIT', _SourcePID, normal} ->
gather(L, Ref, Timeout, Acc);
{'EXIT', _SourcePID, Reason} ->
_ = [exit(P, Reason) || P <- L],
wait_until_dead(L),
exit(Reason)
Expand Down
15 changes: 15 additions & 0 deletions test/spr_util_eunit.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,21 @@ pmap_test_() ->
PossibleRemains = PidsAfter -- PidsBefore,
?assertMatch([], [P || P <- PossibleRemains, is_process_alive(P)])
end),
% Ensure that when a semi-related process exits cleanly we do not kill the workers
?_test(begin
Input = lists:seq(1, 5),
Worker = fun (Value) -> timer:sleep(1000), Value end,
erlang:spawn_link(fun() -> timer:sleep(100), exit(self(), normal) end),
Results = spr_util:pmap(Worker, Input),
?assertEqual(Input, Results)
end),
% Check that an error in the worker causes the error to be returned
?_test(begin
Input = lists:seq(1, 5),
Worker = fun (1) -> exit(normal); (Value) -> Value end,
Results = spr_util:pmap(Worker, Input),
?assertEqual([{'EXIT', normal}, 2, 3, 4, 5], Results)
end),
%% The trap_exti flag for the caller is kept as it was
?_test(begin
Self=self(),
Expand Down