Updating to export jQuery object, currently require('jqueryify') yields undefined.#5
Open
richard-flosi wants to merge 1 commit intospine:masterfrom
richard-flosi:master
Open
Updating to export jQuery object, currently require('jqueryify') yields undefined.#5richard-flosi wants to merge 1 commit intospine:masterfrom richard-flosi:master
richard-flosi wants to merge 1 commit intospine:masterfrom
richard-flosi:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use jquerify 2.1.0, but require('jqueryify') is returning undefined.
This pull request results in the jQuery object getting set on the window as expected.
I'm not sure of the intention of the noGlobal check. The value of noGlobal is true. Inverting the conditional yields the desired result, but maybe the solution is better fixed elsewhere.