Skip to content

feat(msteams): expose exact feedback hook facts#2

Closed
jimmypuckett wants to merge 2 commits into
integration/2026.6.11from
spinen/msteams-native-feedback-hooks
Closed

feat(msteams): expose exact feedback hook facts#2
jimmypuckett wants to merge 2 commits into
integration/2026.6.11from
spinen/msteams-native-feedback-hooks

Conversation

@jimmypuckett

@jimmypuckett jimmypuckett commented Jul 16, 2026

Copy link
Copy Markdown
Member

What Problem This Solves

Microsoft Teams can return reactions and written feedback for a specific agent response, but the channel did not expose enough native hook data to bind that feedback to the exact provider activity and agent run.

Why This Change Was Made

This adds harness-neutral message hook enrichment and Microsoft Teams native feedback facts. OpenClaw emits provider-confirmed response IDs with the concrete run ID, exact reply targets for inbound messages, and typed untrusted reaction/comment facts. It does not contain an Ops-specific schema, persistence, deployment, or remediation behavior.

User Impact

Operator-managed hooks can correlate a Teams response, reaction, or threaded comment without guessing from conversation order. Consumers remain responsible for validation, redaction, retention, and fail-closed handling when a provider identifier is absent.

Evidence

  • Microsoft Teams focused tests: 78 passed
  • Canonical hook mapper tests: 14 passed
  • Exact-file oxlint: passed
  • git diff --check: passed
  • Full root TypeScript check exceeded the local 4 GB heap; the extension-only command is not a supported standalone check because workspace SDK aliases are generated by the root build.

Review Notes

  • Reaction removals intentionally do not invent a superseded add-event ID.
  • Provider fields and written feedback are explicitly marked untrusted.
  • Response content is bound at the provider-confirmed send callback, including partial-send recovery.
  • Draft only; no deployment or runtime configuration change is included.
  • The audited pilot currently runs OpenClaw core 2026.6.10 with the Teams plugin reported as 2026.6.11. This patch changes core reply/internal-hook contracts as well as the plugin, so it is not a plugin-only drop-in for that pilot. Deployment requires either a separately reviewed 2026.6.10 core backport or a separately authorized core upgrade; neither is part of this PR.

AI Assistance

AI-assisted implementation and tests; human review and merge are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant