Skip to content

Fix inaccurate items (batch 3) - #238

Merged
itowlson merged 3 commits into
spinframework:mainfrom
ChihweiLHBird:zhiwei/doc-improve-3
Aug 13, 2026
Merged

Fix inaccurate items (batch 3)#238
itowlson merged 3 commits into
spinframework:mainfrom
ChihweiLHBird:zhiwei/doc-improve-3

Conversation

@ChihweiLHBird

Copy link
Copy Markdown
Contributor
  • cache.md: correct the Homebrew plugin and template paths, which include an etc segment
  • http-outbound.md: service chaining enforces the request scheme rather than ignoring it
  • install.md: add the wasm32-wasip2 target, drop the unused wasm32-unknown-unknown, and correct the minimum Rust version to 1.94 (source)
  • javascript-components.md: the JS/TS template install provides four templates, not two
  • manifest-reference.md: key_value_stores accepts any label mapped in the runtime configuration, not only default
  • quickstart.md: list all four JS/TS templates in the install and spin new output
  • quickstart.md: correct the Rust SDK minimum version to 1.93 (source)
  • rust-components.md: make the Redis manifest parse by adding [application], and define the echo-message component

@ChihweiLHBird ChihweiLHBird changed the title Fix inaccurate items across seven v4 doc pages Fix inaccurate items (batch 3) Aug 4, 2026
Comment thread content/v4/http-outbound.md Outdated
Comment thread content/v4/manifest-reference.md
Comment thread content/v4/quickstart.md Outdated
Comment thread content/v4/rust-components.md Outdated
@ChihweiLHBird
ChihweiLHBird requested a review from itowlson August 12, 2026 05:18
@itowlson

Copy link
Copy Markdown
Contributor

@ChihweiLHBird It looks like there are a couple of commits that need a DCO signoff (not sure which ones, sorry). Otherwise LGTM!

@itowlson
itowlson enabled auto-merge August 12, 2026 22:54
auto-merge was automatically disabled August 12, 2026 23:09

Head branch was pushed to by a user without write access

- cache.md: correct the Homebrew plugin and template paths, which include an `etc` segment
- http-outbound.md: service chaining enforces the request scheme rather than ignoring it
- install.md: add the `wasm32-wasip2` target, drop the unused `wasm32-unknown-unknown`, and correct the minimum Rust version to 1.94
- javascript-components.md: the JS/TS template install provides four templates, not two
- manifest-reference.md: `key_value_stores` accepts any label mapped in the runtime configuration, not only `default`
- quickstart.md: list all four JS/TS templates, and correct the Rust SDK minimum to 1.93
- rust-components.md: make the Redis manifest parse by adding `[application]`

Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
@ChihweiLHBird

Copy link
Copy Markdown
Contributor Author

@itowlson I fixed the DCO check, but the build is failing again due to the broken invitation link...

@itowlson

itowlson commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Well, that's infuriating. I'm re-running the action to see if it's a flake. Otherwise I guess we'll have to exclude it from the link checker. 403 so no idea what's going on there. It seems to 200 from curl so 🤷

@ChihweiLHBird

Copy link
Copy Markdown
Contributor Author

I think it could be some sort of WAF or CDN blocked the GitHub Action runner IP address.

…script

Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
…ntu environment

- Changed `runs-on` from `ubuntu-24.04` to `ubuntu-latest` in build, deploy-preview, and deploy workflows.
- Updated `actions/checkout` from version `v4` to `v7` in all workflows.
- Updated `actions/setup-node` from version `v4` to `v7` in the build workflow.
- Updated `actions/upload-artifact` from version `v4` to `v7` in the build workflow.
- Updated `actions/download-artifact` from version `v4` to `v8` in the deploy workflow.
- Updated `crazy-max/ghaction-import-gpg` from version `v6` to `v7` in the update-cli-reference workflow.
- Updated `peter-evans/create-pull-request` from version `v7` to `v8` in the update-cli-reference workflow.

Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
@itowlson
itowlson enabled auto-merge August 13, 2026 03:39
@itowlson
itowlson merged commit 071f677 into spinframework:main Aug 13, 2026
3 of 4 checks passed
@ChihweiLHBird
ChihweiLHBird deleted the zhiwei/doc-improve-3 branch August 13, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants