Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Asyncify cron#40

Merged
itowlson merged 4 commits into
spinframework:mainfrom
itowlson:asyncify
Apr 21, 2026
Merged

Asyncify cron#40
itowlson merged 4 commits into
spinframework:mainfrom
itowlson:asyncify

Conversation

@itowlson

Copy link
Copy Markdown
Contributor

Tested the Rust guest.

@vdice @dicej How should I update the Python guest (https://github.com/itowlson/spin-trigger-cron/tree/asyncify/guest-python)? I assume there is a new componentise-py and then... just async/await all the things, or more than that? Thanks!

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@vdice

vdice commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

@itowlson yes it should just amount to updating the python deps to match any of the current SDK examples, eg hello and then async-ifying the function and await-ing the variables.get call.

@itowlson

Copy link
Copy Markdown
Contributor Author

@dicej Vaughn and I are struggling with the Python guest. The build is failing with "AssertionError: No world named spin:cron/spin-cron@3.0.0 found in any of the loaded WIT packages." and we can't figure out why. Do you have bandwidth to try it? Thanks!

(There may well be other problems too... I just haven't got past that first one yet...)

@dicej

dicej commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Sorry, somehow I missed the GitHub notifications for this. Will take a look now.

@dicej

dicej commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

The Python issue is a bug in componentize-py which requires some non-trivial refactoring and serves as a reminder that its CLI interface needs more automated testing. I've started both of those things, but they'll take some time. Hoping to have a new release out tomorrow.

@dicej

dicej commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

The componentize-py issue is addressed in bytecodealliance/componentize-py#213. Once CI finished, I'll merge, and then once CI produces the new artifacts, I'll publish a release.

@dicej

dicej commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

I've published the componentize-py version. I wasn't able to push directly to this PR's branch, but here's a PR for the PR: itowlson#1

itowlson and others added 3 commits April 21, 2026 13:17
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson

Copy link
Copy Markdown
Contributor Author

Updated to v4 final @fibonacci1729

Comment thread Cargo.toml
spin-factors = { git = "https://github.com/spinframework/spin", tag = "v3.6.3" }
spin-runtime-factors = { git = "https://github.com/spinframework/spin", tag = "v3.6.3" }
spin-trigger = { git = "https://github.com/spinframework/spin", tag = "v3.6.3" }
spin-factors = { git = "https://github.com/spinframework/spin", rev = "5f3aa19c50d1609592f7ea2f6362209a04da52ac" }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be tag = "v4.0.0"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's the commit so it doesn't really matter.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could. We're pretty good about not changing tags.

@itowlson itowlson merged commit 644fc81 into spinframework:main Apr 21, 2026
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants