This repository was archived by the owner on May 12, 2026. It is now read-only.
Asyncify the MQTT trigger - #74
Merged
Merged
Conversation
itowlson
marked this pull request as ready for review
April 13, 2026 21:53
itowlson
requested review from
fibonacci1729,
karthik2804,
radu-matei and
suneetnangia
as code owners
April 13, 2026 21:53
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
asyncify-export
branch
from
April 13, 2026 22:08
c5a8dd9 to
46758f4
Compare
Contributor
Author
|
Okay I managed to run the example guest locally after all and it looks like it works. It's hardly a comprehensive test but hopefully not much has changed to need further exercising...! |
vdice
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't been able to test this because
make testjust goes "MQTT broker failed to start" - if anyone has successfully tested this before then could they give it a go please? Thanks!