Allow embedders flexibility in how they register their metrics - #3663
Open
rylev wants to merge 1 commit into
Open
Allow embedders flexibility in how they register their metrics#3663rylev wants to merge 1 commit into
rylev wants to merge 1 commit into
Conversation
Signed-off-by: Ryan Levick <rlevick@akamai.com>
itowlson
reviewed
Aug 16, 2026
itowlson
left a comment
itowlson
left a comment
Collaborator
There was a problem hiding this comment.
I had one question but basically this looks fine as far as I know, but I would really like it if Caleb could take a look. If he doesn't have bandwidth then I'm happy to merge it.
| spin_version: String, | ||
| /// | ||
| /// Exposed publicly so embedders that manage their own [tracing::Subscriber] (and so can't call | ||
| /// [`crate::init`], which also installs one) can still set up Spin's metrics: build a provider |
Collaborator
There was a problem hiding this comment.
This made me wonder if crate::init should be offering more flexibility to consumers (with the CLI defaults hived off to an init_default kind of function). But I'm not familiar with the telemetry subsystem so I'm fine with this less invasive change! But I'd like @calebschoepp to look it over too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
metrics_providerso that the embedders can modify and and ultimately register throughset_meter_providerin the way they see fit.