Skip to content

Fixed Sidekiq/Client to conform with more recent Sidekiq spe #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kapunakap wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed Sidekiq/Client to conform with more recent Sidekiq spe #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e18c28f
Fixed Sidekiq/Client
kapunakap Dec 25, 2016
457ef00
Update composer.json
kapunakap Dec 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "spinx/sidekiq-job-php",
"name": "hosportal/sidekiq-job-php",
"description": "Push and schedule jobs to Sidekiq from PHP",
"type": "library",
"license": "MIT",
Expand Down
2 changes: 2 additions & 0 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,11 @@ public function pushBulk($jobs = [], $queue = self::QUEUE)
*/
private function atomicPush($jobId, $class, $args = [], $queue = self::QUEUE, $retry = true, $doAt = null)
{
/* OUTDATED SIDEKIQ SPEC
if (array_values($args) !== $args) {
throw new Exception('Associative arrays in job args are not allowed');
}
*/

if (!is_null($doAt) && !is_float($doAt) && is_string($doAt)) {
throw new Exception('at argument needs to be in a unix epoch format. Use microtime(true).');
Expand Down