Examples for filtering grib data within a provided shapefile area#3
Open
elliott-spire wants to merge 10 commits into
Open
Examples for filtering grib data within a provided shapefile area#3elliott-spire wants to merge 10 commits into
elliott-spire wants to merge 10 commits into
Conversation
0fc4755 to
13a6c75
Compare
kxfeldhus
suggested changes
May 22, 2020
kxfeldhus
left a comment
Contributor
There was a problem hiding this comment.
These examples all share much of the same code. We should pull out common functions so they can be shared in these examples and by end users. Maybe a grib_utils module or something would be handy.
| AREA = shpfile.GetLayer() | ||
|
|
||
| # Compute the wind speed | ||
| def wind_speed_from_u_v(row): |
Contributor
There was a problem hiding this comment.
The wind speed and direction conversions can be found in conversions.py.
e7c964f to
a057708
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.