Skip to content

Fix Dockerfile for training environment#85

Draft
Copilot wants to merge 4 commits into
mainfrom
copilot/create-dockerfile-training-env
Draft

Fix Dockerfile for training environment#85
Copilot wants to merge 4 commits into
mainfrom
copilot/create-dockerfile-training-env

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 22, 2026

The existing Dockerfile had multiple broken steps that would cause the build to fail and produce an incorrect training environment.

Fixes

  • Broken npm install: COPY app*/package*.json + loop over app*/ matched nothing — replaced with explicit COPY service/package*.json service/ + COPY data/package*.json data/ and dedicated npm install per directory
  • Conflicting JAX install: pip install -U "jax[cuda12]" ran outside the virtualenv and clobbered the jax-cuda13-pjrt/jax-cuda13-plugin pins already in requirements.txt — removed; requirements.txt is the sole source of truth for JAX+CUDA
  • Wrong Makefile targets: make datamake datas, make protos/make protos
  • Redundant proto step: standalone python protos/scripts/make_enums.py is already executed inside compile_protos.sh (invoked by make protos)
  • Wrong CMD path: /start.sh/app/start.sh

Improvements

  • Replaced pip install virtualenv && virtualenv env with stdlib python3 -m venv env (adds python3-venv to apt layer)
  • Consolidated protobuf-compiler into the single apt layer; added rm -rf /var/lib/apt/lists/*
  • Protolint extracted to /tmp first, then only the binary moved to /usr/local/bin
  • Combined two npm install -g calls into one layer
  • Upgraded Node.js from 18.x → 20.x LTS
  • Virtualenv explicitly activated in make datas and make protos RUN layers

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] Add Dockerfile for training environment Fix Dockerfile for training environment Mar 22, 2026
Copilot AI requested a review from spktrm March 22, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants