CSPL-3775 extract common code in tests#1788
Open
kasiakoziol wants to merge 51 commits intodevelopfrom
Open
Conversation
* CSPL-4397 Remove time dependency from tests * CSPL-4397 Removing test reliance on time * CSPL-4397 Adjusting timeouts * CSPL-4354 Fixing time dependencies in unit tests and fixing timeouts in integ tests * CSPL-4397 Move to using watch * CSPL-4397 Refactor pod reset detection to use UID-based tracking instead of time-based comparison, add fail-fast test prerequisites validation, and improve code clarity with variable renaming * CSPL-4397 Refactoring * CSPL-4397 Addressing comments
…1768) * CSPL-4602 Moving duplicated code for LM tests to a shared codebase * CSPL-4602 Addinf license manager tests to workflows * CSPL-4602 Address comments * CSPL-4602 Moving LM shared test utils to licensemanager package * CSPL-4602 Addressing base branch changes
* CSPL-4377 Get rid of not expected panic in tests * CSPL-4377 Check error for app disablement in tests
…t-common-code-in-tests
…t-common-code-in-tests
…ping the test file as a thin dispatch layer
…nts, removing duplicate helpers, replacing inline logic with shared utilities
* Enhance error handling in WaitforPhaseChange and fix variable name in NewTestCaseEnv * Updated WaitforPhaseChange to log an error if the phase transition is not observed within the timeout. * Corrected the variable name check in NewTestCaseEnv to use the provided name instead of an uninitialized envName. * Changed Kind from "ClusterManager" to "ClusterMaster" in ClusterMaster struct. * Update error logging in WaitforPhaseChange to use Error level for timeout observations
…ality is not malformed
…ode, and standardize naming, godoc comments, and constants for consistency
kubabuczak
reviewed
Apr 1, 2026
kasiakoziol
requested review from
Igor-splunk,
gabrielm-splunk,
minjieqiu,
patrykw-splunk,
qingw-splunk,
rlieberman-splunk and
vivekr-splunk
kasiakoziol
changed the title
…perator into feature/test-refactoring
rlieberman-splunk
approved these changes
Apr 8, 2026
kasiakoziol
force-pushed
the
feature/CSPL-3775-extract-common-code-in-tests
branch
from
a49e621 to
2926a35
Compare
patrykw-splunk
approved these changes
Apr 10, 2026
kubabuczak
reviewed
Apr 10, 2026
kubabuczak
approved these changes
Apr 10, 2026
Collaborator
kubabuczak
left a comment
kubabuczak
left a comment
There was a problem hiding this comment.
Great work! Let's merge it and start iterating on top of this change
One thing to double check: Verify CI pipeline label selectors still match reformatted test labels
vivekr-splunk
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It extracts common code under test/ to remove duplicates and enhance test readability and usability.
Key Changes
Testing and Verification
Automated tests
Related Issues
Jira: https://splunk.atlassian.net/browse/CSPL-4515
PR Checklist