Skip to content

feat: Update Telemetry protos #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabriziodemaria wants to merge 1 commit into from
Closed

feat: Update Telemetry protos #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openfeature-provider/src/test/java/com/spotify/confidence/FeatureProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
import com.spotify.confidence.shaded.flags.resolver.v1.ResolveFlagsResponse;
import com.spotify.confidence.shaded.flags.resolver.v1.ResolvedFlag;
import com.spotify.confidence.shaded.flags.types.v1.FlagSchema;
import com.spotify.telemetry.v1.LibraryTraces;
import com.spotify.telemetry.v1.Monitoring;
import com.spotify.telemetry.v1.Types.LibraryTraces;
import com.spotify.telemetry.v1.Types.Monitoring;
import dev.openfeature.sdk.*;
import io.grpc.ManagedChannel;
import io.grpc.Server;
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@
<plugin>
<groupId>com.spotify.fmt</groupId>
<artifactId>fmt-maven-plugin</artifactId>
<version>2.20</version>
<version>2.25</version>
<executions>
<execution>
<phase>validate</phase>
Expand Down
6 changes: 3 additions & 3 deletions sdk-java/src/main/java/com/spotify/confidence/Telemetry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package com.spotify.confidence;

import com.google.common.annotations.VisibleForTesting;
import com.spotify.telemetry.v1.LibraryTraces;
import com.spotify.telemetry.v1.Monitoring;
import com.spotify.telemetry.v1.Platform;
import com.spotify.telemetry.v1.Types.LibraryTraces;
import com.spotify.telemetry.v1.Types.Monitoring;
import com.spotify.telemetry.v1.Types.Platform;
import java.util.concurrent.ConcurrentLinkedQueue;

public class Telemetry {
Expand Down
2 changes: 1 addition & 1 deletion sdk-java/src/main/java/com/spotify/confidence/TelemetryClientInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.spotify.confidence;

import com.spotify.telemetry.v1.Monitoring;
import com.spotify.telemetry.v1.Types.Monitoring;
import io.grpc.*;
import java.util.Base64;
import javax.annotation.Nullable;
Expand Down
23 changes: 15 additions & 8 deletions ...src/main/proto/confidence/telemetry.proto → ...fidence/telemetry/v1/types/v1/types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,17 @@ syntax = "proto3";

package confidence.telemetry.v1;
option java_package = "com.spotify.telemetry.v1";
option java_multiple_files = true;
option java_outer_classname = "TelemetryProto";

import "google/protobuf/descriptor.proto";

message MetricAnnotation {
string name = 1;
string unit = 2;
}

extend google.protobuf.EnumValueOptions {
MetricAnnotation metric = 50641;
}

enum Platform {
PLATFORM_UNSPECIFIED = 0;
Expand Down Expand Up @@ -37,17 +46,15 @@ message LibraryTraces {
}

enum Library {
LIBRARY_UNSPECIFIED = 0;
LIBRARY_UNKNOWN = 0;
LIBRARY_CONFIDENCE = 1;
LIBRARY_OPEN_FEATURE = 2;
LIBRARY_REACT = 3;
}

enum TraceId {
TRACE_ID_UNSPECIFIED = 0;
TRACE_ID_RESOLVE_LATENCY = 1;
TRACE_ID_STALE_FLAG = 2;
TRACE_ID_FLAG_TYPE_MISMATCH = 3;
TRACE_ID_WITH_CONTEXT = 4;
TRACE_ID_UNKNOWN = 0;
TRACE_ID_RESOLVE_LATENCY = 1 [(metric) = {name: "resolve_latency", unit: "ms"}];
TRACE_ID_STALE_FLAG = 2 [(metric) = {name: "stale_flag"}];
}
}
4 changes: 2 additions & 2 deletions sdk-java/src/test/java/com/spotify/confidence/ConfidenceIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
import com.spotify.confidence.shaded.flags.resolver.v1.ResolvedFlag;
import com.spotify.confidence.shaded.flags.types.v1.FlagSchema;
import com.spotify.confidence.telemetry.FakeTelemetryClientInterceptor;
import com.spotify.telemetry.v1.LibraryTraces;
import com.spotify.telemetry.v1.Monitoring;
import com.spotify.telemetry.v1.Types.LibraryTraces;
import com.spotify.telemetry.v1.Types.Monitoring;
import io.grpc.ManagedChannel;
import io.grpc.Metadata;
import io.grpc.Server;
Expand Down