fix: change how we log resolve tester hints#177
Merged
Conversation
nicklasl
force-pushed
the
resolve-tester-log
branch
from
270e12d to
35f2bb5
Compare
nicklasl
force-pushed
the
resolve-tester-log
branch
from
35f2bb5 to
71f70de
Compare
fabriziodemaria
approved these changes
Apr 28, 2025
| import "google/protobuf/struct.proto"; | ||
|
|
||
| package confidence.internal.v1; | ||
| option java_package = "com.spotify.internal.v1"; |
Member
There was a problem hiding this comment.
A bit sad we need to leak this naming, but not a big deal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolver hint logs will now contain a base64 encoded string which can be pasted in the Confidence tools to support that we don't necessarily know the URL the user would want to use.