Skip to content

fix: default resolve timeout 5 sec #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicklasl wants to merge 1 commit into from
Closed

fix: default resolve timeout 5 sec #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk-java/src/main/java/com/spotify/confidence/Confidence.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ public static class Builder {
private ManagedChannel flagResolverManagedChannel = DEFAULT_CHANNEL;
private boolean disableTelemetry = false;
private boolean isProvider = false;
private int resolveDeadlineMs = 10_000;
private int resolveDeadlineMs = 1_000;
Copy link
Member Author

@nicklasl nicklasl Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private int resolveDeadlineMs = 1_000;
private int resolveDeadlineMs = 5_000;

private int eventSenderDeadlineMs = 5_000;

public Builder(@Nonnull String clientSecret) {
Expand Down