This repository was archived by the owner on Jan 14, 2026. It is now read-only.
Conversation
ao2017
reviewed
Jun 4, 2021
Contributor
ao2017
left a comment
ao2017
left a comment
There was a problem hiding this comment.
I am not sure this implementation will work. Look at line 65. distRef is not completely protected. I prefer to keep this implementation till we get a lock free one.
rulle-io
reviewed
Oct 15, 2021
|
|
||
| private static final int COMPRESSION_DEFAULT_LEVEL = 100; | ||
| private final AtomicReference<TDigest> distRef; | ||
| private volatile TDigest dist; |
There was a problem hiding this comment.
Since dist is covered by synchronized everywhere, does it really need to be a volatile?
Member
Author
There was a problem hiding this comment.
Line 85 references dist without being synchronized, so the read might see a stale copy
There was a problem hiding this comment.
I'd make it synchronized as well instead (like this e.g.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.