Allow spot network client to run in a separate ns.#43
Open
PrabhdeepsGill wants to merge 3 commits intospotinst:mainfrom
Open
Allow spot network client to run in a separate ns.#43PrabhdeepsGill wants to merge 3 commits intospotinst:mainfrom
PrabhdeepsGill wants to merge 3 commits intospotinst:mainfrom
Conversation
Spot network client can be created in a different namespace from "kube-system".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If users need to run ocean network client in a namespace other than "kube-system", they can override the namespace values in the values file. But the helm chart still assumes that the spot controller is installed in the same namespace.
However, Terraform module for installing the spot controller has hard coded "kube-system" namespace for the controller (tf module with hardcoded namespace). This change allows creating the ocean network client (beta) in a namespace other than "kube-system".