Initial commit for WASB MVP#177
Conversation
|
|
||
| <parent> | ||
| <groupId>org.springframework.cloud.stream.app</groupId> | ||
| <artifactId>spring-cloud-stream-app-starters</artifactId> |
There was a problem hiding this comment.
Shoud use starter-parent as the parent, at least at the time of writing
There was a problem hiding this comment.
This conflicts with how the aws-s3 parent is defined - I used this as a template. Please advise, as I get build errors trying to make it starter-parent
|
Hello @kdunn-pivotal ! Sorry for such a big delay and really thank you for the effort in the Azure direction 😄 . I'm not familiar with that yet, but hope to study something together with you reviewing your PRs or so. We can finish this Blob storage application and then move the code for adapter into Spring Integration Azure project. Or can do that right now and have some divided work. Let me know what works for you better! A general comment: it is much better to make changes in the top level branch, not Consider to do that now and close this PR in favor of proper one against correct branch. @sabbyanandan , do we need a GH-issue story for this or just PR is enough? P.S. Big thanks to @ericbottard for review in SCSt style. I would definitely miss those cases 😉 |
| <repository> | ||
| <id>maven2-repository.dev.java.net</id> | ||
| <name>Java.net repository</name> | ||
| <url>http://download.java.net/maven/2</url> |
There was a problem hiding this comment.
Why do we need this extra repository?
If it is for Azure, I think it is there in the Central already: http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22azure-storage%22
There was a problem hiding this comment.
Great question. I'm not much of a Java wonk so I didn't try to scrub the poms to be minimal...
|
You have done something wrong, my friend, in the latest commit. |
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <java.version>1.8</java.version> |
There was a problem hiding this comment.
I'm not that we have moved to Java 8 already here...
I assume that we fully rely on the Spring Boot options from the top-level parent.
4 participants
Azure isn't currently implemented in Spring Integration so this is wildly different than how the S3 sink looks (with very limited functionality). I basically just implemented the "hello world" from the MS reference and tested two variations of SCDF streams, as shown in the README.
Mainly looking to provide a template to iterate on and get feedback on best practices for these types of modules.
Thanks,
Kyle