Harmonize ObservationConvention parameters in gRPC support#49787
Merged
snicoll merged 2 commits intospring-projects:mainfrom Mar 26, 2026
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
changed the title
GrpcClientObservationConvention to convention
philwebb
added
type: task
Member
|
Woops that name is odd, good catch @therepanic! |
See spring-projectsgh-49787 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
snicoll
changed the title
Such parameters are usually named "customConvention" so this commit aligns to that naming. See spring-projectsgh-49730
snicoll
force-pushed
the
polish-GrpcClientObservationAutoConfiguration
branch
from
596f886 to
d7a4561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's rename
GrpcClientObservationConventiontoconventionto maintain style and consistency withGrpcServerObservationAutoConfiguration