fix: don't delegate client alias choosing for ssl bundles#49838
Open
MezinK wants to merge 1 commit intospring-projects:mainfrom
Open
fix: don't delegate client alias choosing for ssl bundles#49838MezinK wants to merge 1 commit intospring-projects:mainfrom
MezinK wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: MezinK <mezinkocahal@hotmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
MezinK
force-pushed
the
alias-support-for-client-ssl-bundles
branch
from
4a3acd4 to
427cdd3
Compare
MezinK
changed the title
Member
|
We should consider the discussion in #44629 when reviewing this proposal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
.key.aliasspecified inside of an SSL Bundle is not taken into account when dealing with client certificates.This causes the delegate (usually
SunX509KeyManagerImpl) to just pick the first alias it finds.For requests requiring mTLS, this can cause issues if the certificates are inside of a shared keystore, as you may not get the certificate that you would want.
I have created an example repo demonstrating this behavior:
https://github.com/MezinK/spring-boot-mtls-demo