Fix command highlighter #1283
Closed
Fix command highlighter #1283
+124
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Olaszewski <piotr.olaszewski@thulium.pl>
| public void setErrorIndex(int errorIndex) { | ||
| } | ||
| }) | ||
| .highlighter(new CommandHighlighter(commandRegistry)) |
Contributor
There was a problem hiding this comment.
I would autowire the CommandHighlighter here instead of using new (similar to how the CommandCompleter is autowired as well). I will take care of that on merge.
| * @author Piotr Olaszewski | ||
| * @since 4.0.1 | ||
| */ | ||
| public class CommandHighlighter implements Highlighter { |
Contributor
There was a problem hiding this comment.
It's great that you have extracted the highlighter in a separate class 👍 That's how I would have done it as well.
fmbenhassine
added a commit
that referenced
this pull request
Jan 28, 2026
- Use dependency injection for CommandHighlighter - Add Javadoc - Add missing license headers - Rename test class - Remove wildcard imports
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1277
Bonus:
pom.xml(tabs)package-info.java