This repository was archived by the owner on Jul 21, 2019. It is now read-only.
Update for Amazon Linux and general linting#15
Open
davidski wants to merge 45 commits into
Open
Conversation
Author
|
Is there anything I can do to help review and get this PR merged? |
Contributor
|
David, Thanks for all your hard work on this. It's kind of been off our radar. We'll try to take a look at the patch soon. Looks like the travis build is failing though. Could you take a peek and see if tests need tweaked? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A larger PR than I intended, this is primarily for AWS Linux support:
Sorry for the scope on this change. I'm trying to close out my own forks. If accepted, I'll
do another pass to bring the R Studio version more current and update for the recent shift
to cookstyle away from rubocop.