Fix all whitespace -- alternative approach#216
Closed
dpoetzsch wants to merge 13 commits intospullara:masterfrom
Closed
Fix all whitespace -- alternative approach#216dpoetzsch wants to merge 13 commits intospullara:masterfrom
dpoetzsch wants to merge 13 commits intospullara:masterfrom
Conversation
This reverts commit d611bed.
Owner
|
I checked out this branch and ran the spec tests and it looks like whitespace differences still occur. Does the branch still require it to be enabled? |
Contributor
Author
|
This branch is not perfect yet. It shows how a tiny bit of performance could be achieved by adding a lot more complexity. I just wanted to show how we might be able to avoid reparsing the output, but because of the new complexities with async writers I personally would prefer the solution of #215. So I close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented an alternative approach that avoids reparsing the output for newlines in the
IndentWriter.Basic idea was to use a specialized
IndentWritereverywhere. This way, we can call the newline-specialized methodwriteLinesinappendText.Note however, that besides changing a lot of interfaces this implementation made the implementation of the
LatchedWritera lot more complicated because it also needs to be newline aware in its buffer.