Open
Conversation
Added scala 2.11 support to mustache.java-0.8.x
0.8.x: add TwitterObjectHandler to scala-extensions-2.10 and -2.11
… no quotes for attributes
DeepCode's analysis on #06d95d found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the error
So I'm going to suggest a solution and I think it would be fine to modify my code like this.
if, else syntax
If the conversion parameter contained in it is an OS parameter, the OS parameter value is given priority to change the value. So for now, it's time to delete the code that converts the environment first.
*** example error syntax ( OS environment)
window OS enveronment value => %USERNAME%
{{#userName}}
{{userName}}
{{/userName}}
{{^userName}}
{{/userName}}
************ Referral Code
import com.samskivert.mustache.DefaultCollector;
import com.samskivert.mustache.Mustache.VariableFetcher;
import java.util.Map;
public class CustomMustacheColletor extends DefaultCollector {
@OverRide
public VariableFetcher createFetcher(Object ctx, String name) {
VariableFetcher fetcher = super.createFetcher(ctx, name);
if (fetcher != null ) {
return fetcher;
}
}
}
*************** MustacheEnvironmentCollector.java
@OverRide
public VariableFetcher createFetcher(Object ctx, String name) {
VariableFetcher fetcher = super.createFetcher(ctx, name);
if (fetcher != null) {
return fetcher;
}
if (this.environment.containsProperty(name)) {
return this.propertyFetcher;
}
return null;
}
===>
@OverRide
public VariableFetcher createFetcher(Object ctx, String name) {
VariableFetcher fetcher = super.createFetcher(ctx, name);
if (fetcher != null) {
return fetcher;
}
return null;
}
****** this code deleted
if (this.environment.containsProperty(name)) {
return this.propertyFetcher;
}