Add in operator#520
Open
sbundaz wants to merge 9 commits into
Open
Conversation
Contributor
|
In general this looks good to me! A few thoughts:
|
Contributor
|
After a little more testing, I think you'll need to add some additional traps for non-matching types of generic containers.. For instance, this is currently an error: def main() -> None:
x = [1,2,3]
"1" in xTypeError: mismatched types
| /workspaces/spy/a.spy:4
| print("1" in x)
| |_| expected `i32`, got `str`
| /workspaces/spy/stdlib/_list.spy:364
| def __contains__(self, value: T) -> bool:
| |______________________________________| function defined here
| /workspaces/spy/a.spy:4
| print("1" in x)
| |______| operator::IN called hereWhereas it probably wants to just return False. |
Member
I'm happy to be convinced otherwise, but I think this should be an error, unless it's list[object] or list[dynamic]. I made the same choice for e.g. ==: |
Member
|
@sbundaz sorry it's taking so long to review, I hope to get to it soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #407
This PR adds the
inoperator.