Nicer playground#560
Merged
Merged
Conversation
antocuni
approved these changes
Jun 13, 2026
antocuni
left a comment
antocuni
left a comment
Member
There was a problem hiding this comment.
LGTM, apart the annotations comments.
If possible, I think it would be better to keep its mypy config consistent with all the other test files, and then we don't need the annotations.
Feel free to merge after doing it!
|
|
||
| @pytest.fixture | ||
| def init(self, tmpdir, _rodney): | ||
| def init(self, tmpdir: pytest.TempdirFactory, _rodney: Rodney) -> None: |
Member
There was a problem hiding this comment.
I think this annotation is wrong: tmpdir should be a py.path.local I think
Member
There was a problem hiding this comment.
but also, note that for files in spy/tests/ we have a special mypy.ini config specifically made to be able to use pytest fixtures without going crazy with annotations:
Lines 7 to 9 in 515c013
so maybe we should do the same for this test file?
paugier
force-pushed
the
nicer-playground
branch
from
1fcf071 to
2057ce7
Compare
Merged
paugier
added a commit
that referenced
this pull request
Jun 14, 2026
I broke the playground with my PR #560. This should fix it by copying the right directories for the playground.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several relatively small improvements of the playground.
The most important change is the fact that the playground now includes all examples in the four numbered categories (1_high_level, 2_metaprogramming, 3_low_level and 4_advanced).
Note: I used Claude for this!