Implement str.split()#562
Open
JeffersGlass wants to merge 7 commits into
Open
Conversation
Member
|
I haven't reviewed it yet but please note that we DO have support for default args. However, we don't have str|None yet, so str.split is still not easily typeable (but we could do it with a metafunc) |
Contributor
Author
Oh! I honestly don't think I knew that... exciting! Don't sweat renewing this - I'm not sure if I've broken something by changing things in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
str.split(sep)to the stdlib. Note that the separator has to be explicitly specified; this does not implementsplit()which splits on whitespace, which should probably wait until we have default arguments.Also implements
WasmFuncWrapper._to_pylist_str()to get lists back out of wasm tests.