Initial support for other schemas#141
Closed
aokiji wants to merge 3 commits intosqls-server:masterfrom
Closed
Conversation
added 3 commits
March 20, 2024 22:53
tries to add some support for completion when working with other schemas. join snippets are not supported yet as foreign key information gathered for the other schemas is not updated in the cache as it is done with the column description this partially solves issue sqls-server#99
querying information schema views is slow, and more so when joining multiple of these relations some of these queries have been changed to query the catalog tables instead
Author
|
I'm closing this issue as I rather divide the performance issue and the feature proposal so that is easier to review, the feature proposal is now in #142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in #99 there is lack of support for completion when working with other schemas other than the default schema. So this in the initial effort to fix this issue bringing support for:
In this change there is also a performance change proposal for the queries that retrieve schema information. In my database (~3k tables, ~25k columns) the sqls server hunged up in the foreign key query for the primary cache, after the change it starts up almost instantly