register available commands in ExecuteCommandProvider#193
Open
MrTomatePNG wants to merge 3 commits intosqls-server:masterfrom
Open
register available commands in ExecuteCommandProvider#193MrTomatePNG wants to merge 3 commits intosqls-server:masterfrom
ExecuteCommandProvider#193MrTomatePNG wants to merge 3 commits intosqls-server:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! I've been using this project and I like the premise.
I am currently developing a small extension to integrate this LSP into the Zed editor ([repo here](https://github.com/MrTomatePNG/zed-sqls-extension)). However, I ran into an obstacle: Zed is quite strict about LSP capabilities. During startup, it requires the server to register available commands in advance. If they are not registered during the initialization phase, Zed's UI simply ignores them, even if the LSP reports them as available later.
I initially built a small proxy to intercept and inject these capabilities, but since the fix is straightforward, I believe it's better to implement it directly here. This PR adds the explicit command registration to the
ExecuteCommandProvider:Since this change only clarifies the server's capabilities during the initial handshake, it is non-breaking and should not affect other editors like Vim, Emacs, or Sublime Text.
I look forward to your feedback, I have other ideas with LSP protocol
