fix: Skip the module metadata file during discovery - #61
Closed
boblail wants to merge 1 commit into
Closed
Conversation
The metadata file describes a module; it is never itself a command. Packages sometimes ship it with the executable bit set, and discovery would then match it against the executable contracts and probe it — producing errors like `fork/exec .../.sq-module: exec format error` (or, with the default '.exoskeleton' filename, a phantom subcommand with an empty name, since stripping the extension leaves nothing). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
This is a bug in the upstream command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A module's metadata file describes the module; it is never itself a command. But when a package ships the file with the executable bit set, discovery matches it against the executable contracts and probes it — failing with
fork/exec .../.sq-module: exec format erroron every invocation (we see this in the field via sq's error telemetry), or, with the default.exoskeletonfilename, producing a phantom subcommand with an empty name since stripping the extension leaves nothing.The discoverer now carries the configured metadata filename and skips that entry when enumerating a directory. No behavioral change for metadata files without the executable bit, which no contract matched anyway.
🤖 Generated with Claude Code