Skip to content
This repository was archived by the owner on Apr 29, 2020. It is now read-only.

hook env: don't error if POD_UNIQUE_KEY is empty#1052

Open
mpuncel wants to merge 1 commit intosquare:masterfrom
mpuncel:mpuncel/fix-unique-name
Open

hook env: don't error if POD_UNIQUE_KEY is empty#1052
mpuncel wants to merge 1 commit intosquare:masterfrom
mpuncel:mpuncel/fix-unique-name

Conversation

@mpuncel
Copy link
Collaborator

@mpuncel mpuncel commented May 24, 2018

POD_UNIQUE_KEY is empty for most pods, so it doesn't make sense to
return an error if it's empty, just return an empty string

@mpuncel mpuncel force-pushed the mpuncel/fix-unique-name branch from 94ab9db to 52fb8a0 Compare May 24, 2018 17:16
@mpuncel
Copy link
Collaborator Author

mpuncel commented May 24, 2018

hmm errcheck isn't failing locally for me

@spenceral
Copy link
Collaborator

I'm having the same errcheck issue on my PR (and similarly, it works locally)

@esuen
Copy link
Contributor

esuen commented Jun 19, 2018

In order to fix the errcheck issue you need to add something to your Rakefile, I should have already applied this change to the master branch.

Your errcheck in Rakefile should look like

task :errcheck do
  e "exit $(errcheck -ignoretests -ignore \"fmt:.*\" github.com/square/p2/pkg/... | grep -v defer | wc -l || 1)"
end

This is because errcheck was updated to selectively ignore functions in thefmt package, where the old behavior was to ignore everything in fmt.

POD_UNIQUE_KEY is empty for most pods, so it doesn't make sense to
return an error if it's empty, just return an empty string
@mpuncel mpuncel force-pushed the mpuncel/fix-unique-name branch from 52fb8a0 to adeb45f Compare February 16, 2019 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants