This repository was archived by the owner on Apr 29, 2020. It is now read-only.
refresh some checked fields in addPods#1137
Open
zapman449 wants to merge 10 commits intosquare:masterfrom
Open
refresh some checked fields in addPods#1137zapman449 wants to merge 10 commits intosquare:masterfrom
zapman449 wants to merge 10 commits intosquare:masterfrom
Conversation
zapman449
force-pushed
the
jprice.add-pod-update-state
branch
from
66becb0 to
6555882
Compare
ausmith
reviewed
Nov 19, 2019
| return err | ||
| } | ||
| possible = types.NewNodeSet(eligible...).Difference(types.NewNodeSet(currentNodes...)) | ||
| possibleSorted = possible.ListNodes() |
Collaborator
There was a problem hiding this comment.
Why are we repeating lines 300 and 304 here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.