This repository was archived by the owner on Sep 25, 2019. It is now read-only.
Open
Conversation
…-mysql * 'master' of https://github.com/square/prodeng: Update README.md Update README.md Update README.md fixes for darwin for new metrics scheme various improvements
* upstream/master: Update README.md Update README.md
add metrics and fix bugs * brian-mysql: more metrics in mysqlstat files added enable password from config file get global status started wrote mysqlstat created mysqlstat
inspect-mysql/README.md
Outdated
Collaborator
|
This is great! My biggest concern is that it's non-obvious how to make changes to this code, since there are no tests and no guidance in README. Can you add some documentation for how you develop and test this code (if only manually?) For example, say I wanted to change or fix a bug in the stacked queries check. How would you do that? |
* 'master' of https://github.com/BrianIp/prodeng: Added Testing section to readme Update readme
* upstream/master: add basic cgroup based resource container script add per process IO statistics add fsstats for linux
Contributor
There was a problem hiding this comment.
Why is the lock needed here?
Contributor
Author
There was a problem hiding this comment.
Maps aren't thread safe. There's a potential race condition where two different threads might try to create new entries and initialize metrics for the same entry in a map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.