Fix TypeScript func_start regex to avoid matching parameter annotations - #1771
Closed
squid-protocol wants to merge 2 commits into
Closed
Fix TypeScript func_start regex to avoid matching parameter annotations#1771squid-protocol wants to merge 2 commits into
squid-protocol wants to merge 2 commits into
Conversation
Improved TypeScript func_start regex to correctly detect arrow functions inside object literals, reducing missed function detections and argument count mismatches.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the TypeScript
func_startregex where it would mistakenly match parameter type annotations likef: (...a: A) => Band incorrectly identify them as function starts. The regex now uses a lookahead to ensure that the arrow is followed by a structural boundary (a block{, type arguments<, or parenthesized grouping(), allowing it to correctly identify object-literal arrow functions without matching generic parameter types.This resolves numerous missed function and argument-count mismatches when compared against tree-sitter.
The golden masters for tests have been regenerated and included in this PR.