Skip to content

[BUG] Fix #510: validate_owasp crashes on malformed JWT tokens#523

Open
adityakryadav wants to merge 3 commits into
sreerevanth:mainfrom
adityakryadav:fix/510-owasp-jwt-validation
Open

[BUG] Fix #510: validate_owasp crashes on malformed JWT tokens#523
adityakryadav wants to merge 3 commits into
sreerevanth:mainfrom
adityakryadav:fix/510-owasp-jwt-validation

Conversation

@adityakryadav

Copy link
Copy Markdown
Contributor

Summary

Closes #510.
Calling validate_owasp with a payload containing a malformed JWT token raised an unhandled ValueError (or jwt.DecodeError), crashing the caller with a raw traceback.

Changes

  • agentwatch/security/owasp.py — Added validate_owasp(payload: dict) -> dict:
    • Optionally decodes the token field in the payload using PyJWT (signature verification disabled — format-only check).
    • Catches ValueError and any other exception from the JWT library.
    • Returns a structured dict: {"status": "error", "error": "<message>"} on failure, {"status": "success"} on pass.
    • Never crashes; callers can inspect the returned dict.

How to test

from agentwatch.security.owasp import validate_owasp
# Malformed token — should NOT raise, should return {"status": "error", ...}
result = validate_owasp({"token": "not.a.valid.jwt"})
assert result["status"] == "error"
# No token — should succeed
result = validate_owasp({})
assert result["status"] == "success"

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@adityakryadav, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 32c51955-618d-4bf6-be6b-49a7a13a0908

📥 Commits

Reviewing files that changed from the base of the PR and between 83dafb8 and 0f9f06a.

📒 Files selected for processing (1)
  • agentwatch/security/owasp.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

🧪 PR Test Results

Check Result
Tests (pytest tests/) ✅ success
Lint (ruff check .) ✅ success
Coverage (agentwatch) 73.56%

Python 3.12 · commit 0f9f06a

@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

@adityakryadav is attempting to deploy a commit to the sreerevanth's projects Team on Vercel.

A member of the Team first needs to authorize it.

@sreerevanth sreerevanth left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I think the fix should remain within the existing validate_owasp(events) API. This PR changes the function signature, mixes JWT validation with OWASP scanning, and changes the return type, which could break existing callers. Could you instead identify where malformed JWTs are causing the crash and handle that case while preserving the current API and return type?

@sreerevanth

Copy link
Copy Markdown
Owner

@adityakryadav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] validate_owasp function crashes when processing malformed JWT tokens

2 participants