macos support via sandbox-exec - #17
Conversation
770d2a8 to
47fb1cb
Compare
| # Tmp support | ||
| (lib.mkIf config.features.tmp { | ||
| rw = [ "/tmp" ]; | ||
| rwx = [ "/tmp" ] ++ lib.optionals isDarwin [ "/var/folders" ]; |
There was a problem hiding this comment.
hope you don't mind this change (to rwx), but I was getting error when running yarn, which runs stuff from within temp dir (probably install scripts for packages).
|
Can you provide some context here? Does landrun run on macOS? |
No it does not, that's why this PR is using sandbox-exec, which is the closest things on MacOS. It's a tool deveploped by apple (although not officially documented) and it's used by both claude code and gemini cli . If you are not interested in supporting MacOS and would rather prefer to keep this repo focused on landrun, I'm happy to go my own way. Personally I maintain both linux and apple systems and since I liked the interface landrun-nix provide's I thought it would be nice to use it for both platforms. If you do accept this contribution maybe we could think about renaming the project. |
I'm happy to consider this. This PR currently complects the landrun-nix and macOS stuff. So to best to do this, we need a common interface that now has two implementations which are totally separated out (different files/folders) to make maintenance easier. |
adrian-gierakowski
changed the title
done in #18 |
2 participants
I made some change trying to fix tests in sandbox, but eventually hit not being able to access sandbox-exec binary itself (it's not in nixpkgs)
looks like the only way to make this work would be to use __noChroot
@srid do you have macos builder in CI?